On Tue, 2012-07-03 at 08:13 -0700, Joe Perches wrote:

On Tue, 2012-07-03 at 12:16 +0200, Johannes Berg wrote:

quoted

From: Johannes Berg <redacted>

A lot of code has either the memset or an
inefficient copy from a static array that
contains the all-ones broadcast address.
Introduce broadcast_ether_addr() to fill
an address with all ones, making the code
clearer and allowing us to get rid of the
various constant arrays.

[]

quoted

diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h

[]

quoted

+static inline void broadcast_ether_addr(u8 *addr)
+{
+	memset(addr, 0xff, ETH_ALEN);
+}

I think this sort of patch should come as the first
patch in a series with some example conversions.

It might be too easy to confuse is_broadcast_ether_addr
with this function name too.  Maybe set_broadcast_ether_addr
might be better.

Well, it's void so that'd be a compiler error :-)
Also, it's more like random_ether_addr()

johannes