Re: [PATCH] iwlwifi: re-order module_init order to prevent NULL ptr deref
From: Johannes Berg <johannes@sipsolutions.net>
Date: 2012-06-12 19:17:36
Also in:
lkml, netdev
On Tue, 2012-06-12 at 21:13 +0200, Sasha Levin wrote:
quoted hunk
We need to make sure iwl_drv_init is called before iwl_init, since otherwise iwl_init will NULL ptr deref when trying to add a new mode. Signed-off-by: Sasha Levin <redacted> --- drivers/net/wireless/iwlwifi/Makefile | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/net/wireless/iwlwifi/Makefile b/drivers/net/wireless/iwlwifi/Makefile index 98c8f64..16e39a4 100644 --- a/drivers/net/wireless/iwlwifi/Makefile +++ b/drivers/net/wireless/iwlwifi/Makefile@@ -1,5 +1,3 @@ -obj-$(CONFIG_IWLDVM) += dvm/ -
Thanks! I already have a patch like this in my tree, will send a pull request soon: http://git.kernel.org/?p=linux/kernel/git/iwlwifi/iwlwifi-next.git;a=commit;h=4b75b1e49568dd6a30a1dddc47408cc6fde55608 johannes