Re: [PATCH 5/5] wlcore/wl12xx/wl18xx: make NVS file optional for wl18xx

(added the list back)

On Fri, 2012-06-08 at 09:43 +0300, Arik Nemtsov wrote:

On Fri, Jun 8, 2012 at 9:30 AM, Luciano Coelho [off-list ref] wrote:

quoted

From: Arik Nemtsov <redacted>

Don't spew errors when we can't find the NVS file in wlcore. Instead
fail the wl12xx boot HW op if the NVS isn't found.

Take this opportunity to remove some dead code from register_hw()
which looks for the NVS again needlessly.

Signed-off-by: Arik Nemtsov <redacted>
Signed-off-by: Luciano Coelho <redacted>
---
 drivers/net/wireless/ti/wlcore/boot.c |    4 +++-
 drivers/net/wireless/ti/wlcore/main.c |   22 ++++++----------------
 2 files changed, 9 insertions(+), 17 deletions(-)

diff --git a/drivers/net/wireless/ti/wlcore/boot.c b/drivers/net/wireless/ti/wlcore/boot.c
index ed718f7..7b8e61e 100644
--- a/drivers/net/wireless/ti/wlcore/boot.c
+++ b/drivers/net/wireless/ti/wlcore/boot.c

@@ -211,8 +211,10 @@ int wlcore_boot_upload_nvs(struct wl1271 *wl)
       u32 dest_addr, val;
       u8 *nvs_ptr, *nvs_aligned;

-       if (wl->nvs == NULL)
+       if (wl->nvs == NULL) {
+               wl1271_error("NVS file is need during boot");

Can you fix this message as well? need -> needed (or you can reformat
it completely).

Okay, I'll fix it before applying the patches.  Thanks!

--
Luca.