Re: [PATCH V2] bcma: use custom printing functions
From: Rafał Miłecki <zajec5@gmail.com>
Date: 2012-06-30 09:24:03
2012/6/30 Hauke Mehrtens [off-list ref]:
On 06/29/2012 02:10 PM, Rafał Miłecki wrote:quoted
Having bus number printed makes it much easier to anaylze logs on systems with more buses. For example Netgear WNDR4500 has 3 AMBA buses in total, which makes standard log really messy. Signed-off-by: Rafał Miłecki <zajec5@gmail.com> --- V2: don't create "bus" variable when it's not really helpful don't brak strings John: this applies on top of 5 patches accepted in the [PATCH 0/8] bcma misc updates patchset. So: wireless-testing + bcma: extend workaround for bcm4331 bcma: add constants for chip ids bcma: add PCI ID for BCM43224 bcma: complete workaround for BCMA43224 and BCM4313 bcma: add bcma_pmu_spuravoid_pllupdate() And then: bcma: use custom printing functions applies cleanly :)After applying your patch I still found some pr_ statements in the code, just use "grep pr_ drivers/bcma/ -r", is this intended?
Yes, it is. Sometimes we don't have bus reference (or it doesn't exists at all yet). For such a situations I kept define of pr_fmt - it allows us to still have "bcma: " prefix when using standard pr_<level> functions.
I just send a new version of my patches for bcma, they are now removing some functions form driver_chipcommon_pmu.c so your patch will not apply on them any more.
Yeah, I'll. John: drop this version of patch as it won't apply. -- Rafał