Re: [PATCH 4/6] mac80211: clean up debugging
From: Joe Perches <joe@perches.com>
Date: 2012-06-22 14:37:08
Also in:
netdev
On Fri, 2012-06-22 at 15:14 +0200, Johannes Berg wrote:
From: Johannes Berg <redacted> There are a few things that make the debugging in mac80211 painful: * pr_debug makes it require *both* Kconfig and dynamic configuration -- move to pr_info
pr_info can clutter the log.
* the macros still need trailing newlines
That's not a bad thing.
quoted hunk
@@ -317,7 +318,7 @@ ieee80211_agg_splice_packets(struct ieee80211_sub_if_data *sdata, ieee80211_stop_queue_agg(sdata, tid); if (WARN(!tid_tx, "TID %d gone but expected when splicing aggregates" - " from the pending queue\n", tid)) + " from the pending queue", tid))
defective. Don't remove newlines in single modules. Using a single style _with_ a newline limits defects and limits the likely misuse in other styles.