Re: [PATCH v2] wlcore: fix undefined symbols when CONFIG_PM is not defined
From: Luciano Coelho <hidden>
Date: 2012-05-29 08:33:12
Also in:
linux-next, lkml
From: Luciano Coelho <hidden>
Date: 2012-05-29 08:33:12
Also in:
linux-next, lkml
On Tue, 2012-05-29 at 01:28 -0700, Eyal Shapira wrote:
commit c21eebb50379a96e1335e933583dcd5b455c6b64 "wl12xx: add RX filters ACX commands" breaks the build when CONFIG_PM isn't defined: ERROR: "wl1271_rx_filter_get_fields_size" [drivers/net/wireless/ti/wlcore/wlcore.ko] undefined! ERROR: "wl1271_rx_filter_flatten_fields" [drivers/net/wireless/ti/wlcore/wlcore.ko] undefined! code in drivers/net/wireless/ti/wlcore/acx.c is using these functions unconditionally while they are #ifdefed CONFIG_PM. Fix it by ifdefing all relevant RX filters code with CONFIG_PM. Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> Signed-off-by: Eyal Shapira <redacted> --- v2: reference the correct commit in linux-next (Thanks Stephen!)
Thanks for the correction. For v2: Acked-by: Luciano Coelho <redacted> -- Cheers, Luca.