Thread (5 messages) 5 messages, 4 authors, 2012-05-29

Re: [PATCH] wlcore: fix undefined symbols when CONFIG_PM is not defined

From: Luciano Coelho <hidden>
Date: 2012-05-29 07:21:39
Also in: linux-next, lkml

On Tue, 2012-05-29 at 00:15 -0700, Eyal Shapira wrote:
commit 5063c201d7b799d6cb36d3edfc2c2c3db3b400e5
"wl12xx: add RX filters ACX commands" breaks the build
when CONFIG_PM isn't defined:

ERROR: "wl1271_rx_filter_get_fields_size"
[drivers/net/wireless/ti/wlcore/wlcore.ko] undefined!
ERROR: "wl1271_rx_filter_flatten_fields"
[drivers/net/wireless/ti/wlcore/wlcore.ko] undefined!

code in drivers/net/wireless/ti/wlcore/acx.c is using these
functions unconditionally while they are #ifdefed CONFIG_PM.
Fix it by ifdefing all relevant RX filters code with CONFIG_PM.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Eyal Shapira <redacted>
---
Acked-by: Luciano Coelho <redacted>

Thanks, Eyal!

John, can you push this up so it gets applied for 3.5?

-- 
Cheers,
Luca.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help