Re: [PATCH 00/13] net: Add and use ether_addr_equal
From: Emmanuel Grumbach <hidden>
Date: 2012-05-10 07:08:17
Also in:
bridge, linux-bluetooth, lkml, netdev, netfilter-devel
From: Emmanuel Grumbach <hidden>
Date: 2012-05-10 07:08:17
Also in:
bridge, linux-bluetooth, lkml, netdev, netfilter-devel
quoted
quoted
quoted
That case you didn't convert in mac80211 is probably the bug Johannes was talking about which started this whole discussion.The bug case that started it all is in net/wireless/scan.c and Emmanuel has since changed it back to memcmp(). Not sure if that's the one you were referring to or not :-)That's the one that I left alone. Post patch: $ git grep -n -w compare_ether_addr net net/batman-adv/main.h:198: * note: can't use compare_ether_addr() as it requires aligned memory net/wireless/scan.c:381: return compare_ether_addr(a->bssid, b->bssid);Ok, great, then that means the fix from Emmanuel won't conflict when it gets in.
Thanks Joe - as Johannes said this won't conflict with my patch. And yes the code is now more clear.