Re: [PATCH] mac80211: don't always advertise remain-on-channel
From: Luciano Coelho <hidden>
Date: 2012-03-26 20:10:54
From: Luciano Coelho <hidden>
Date: 2012-03-26 20:10:54
On Mon, 2012-03-26 at 18:47 +0200, Johannes Berg wrote:
From: Johannes Berg <redacted> Not all devices are really capable of implementing remain-on-channel, even if it is implemented in SW, as they can't necessarily deal with channel changes while associated. Remove the WIPHY_FLAG_HAS_REMAIN_ON_CHANNEL and add it only if either the driver has remain_on_channel implemented in the driver/device. Also add it to all drivers that advertise P2P right now since those definitely have to have it working. Signed-off-by: Johannes Berg <redacted> --- I think e.g. wl1251 would completely get fucked up by this .. let's not go there. Also iwlegacy wouldn't like offchannel much, and doesn't need it since it'll never have P2P anyway.
Yes, I'm pretty sure it wouldn't work as is with wl1251. So, let's leave it out. Otherwise, for the wl12xx part: Acked-by: Luciano Coelho <redacted> -- Cheers, Luca.