Re: [PATCH v3 4/4] ath9k: Support ethtool getstats api.

On 03/20/2012 01:42 AM, Florian Fainelli wrote:

Hi,

Le 03/19/12 19:51, greearb@candelatech.com a écrit :

quoted

From: Ben Greear<redacted>

This returns many of the values that formerly could
only be obtained from debugfs. This should be an
improvement when trying to access these counters
programatically. Currently this support is only
enabled when DEBUGFS is enabled because otherwise
these stats are not accumulated.

Signed-off-by: Ben Greear<redacted>
---

v3: No changes from v2

:100644 100644 4a00806... 7261f88... M drivers/net/wireless/ath/ath9k/main.c
drivers/net/wireless/ath/ath9k/main.c | 134 +++++++++++++++++++++++++++++++++
1 files changed, 134 insertions(+), 0 deletions(-)

diff --git a/drivers/net/wireless/ath/ath9k/main.c b/drivers/net/wireless/ath/ath9k/main.c
index 4a00806..7261f88 100644
--- a/drivers/net/wireless/ath/ath9k/main.c
+++ b/drivers/net/wireless/ath/ath9k/main.c

@@ -2430,6 +2430,134 @@ static int ath9k_get_antenna(struct ieee80211_hw *hw, u32 *tx_ant, u32 *rx_ant)

return 0;
}

+#ifdef CONFIG_ATH9K_DEBUGFS

These are ethtool knobs, so you might want to introduce a new config symbol dedicated to it, which depends on CONFIG_ATH9K_DEBUGFS eventually.

I'd like to gather at least most stats always, so ethtool can work regardless of
debugfs.  But, that can be follow on patches in my opinion.  If it turns out
that we need another config option for this, then that is fine too.

Thanks,
Ben

-- 
Ben Greear [off-list ref]
Candela Technologies Inc  http://www.candelatech.com