Thread (1 message) 1 message, 1 author, 2012-03-07
DORMANTno replies

[PATCH] iwlwifi: Add __printf verification

From: Joe Perches <joe@perches.com>
Date: 2012-03-07 20:23:31
Also in: netdev
Subsystem: networking drivers (wireless), the rest · Maintainers: Johannes Berg, Linus Torvalds

Make sure that arguments match formats.
All current uses do.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/wireless/iwlwifi/iwl-debug.h |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
diff --git a/drivers/net/wireless/iwlwifi/iwl-debug.h b/drivers/net/wireless/iwlwifi/iwl-debug.h
index 01b2330..42e6bbb 100644
--- a/drivers/net/wireless/iwlwifi/iwl-debug.h
+++ b/drivers/net/wireless/iwlwifi/iwl-debug.h
@@ -34,10 +34,14 @@
 
 struct iwl_priv;
 
+__printf(4, 5)
 void __iwl_err(struct device *dev, bool rfkill_prefix, bool only_trace,
 		const char *fmt, ...);
+__printf(2, 3)
 void __iwl_warn(struct device *dev, const char *fmt, ...);
+__printf(2, 3)
 void __iwl_info(struct device *dev, const char *fmt, ...);
+__printf(2, 3)
 void __iwl_crit(struct device *dev, const char *fmt, ...);
 
 /* No matter what is m (priv, bus, trans), this will work */
@@ -47,10 +51,12 @@ void __iwl_crit(struct device *dev, const char *fmt, ...);
 #define IWL_CRIT(m, f, a...) __iwl_crit(trans(m)->dev, f, ## a)
 
 #if defined(CONFIG_IWLWIFI_DEBUG) || defined(CONFIG_IWLWIFI_DEVICE_TRACING)
+__printf(6, 7)
 void __iwl_dbg(struct iwl_shared *shared, struct device *dev,
 	       u32 level, bool limit, const char *function,
 	       const char *fmt, ...);
 #else
+__printf(6, 7)
 static inline void
 __iwl_dbg(struct iwl_shared *shared, struct device *dev,
 	  u32 level, bool limit, const char *function,

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help