Re: [PATCH] Cleaning up code formatting errors in net/wireless pointed out by checkpatch.
From: Joe Perches <joe@perches.com>
Date: 2012-02-17 18:45:49
Also in:
lkml, netdev
On Fri, 2012-02-17 at 07:30 -0800, Luis Felipe Strano Moraes wrote:
These are mostly minor changes and they are being sent as one patch only in order to cause the smallest amount of disruption.
[]
quoted hunk ↗ jump to hunk
diff --git a/net/wireless/core.c b/net/wireless/core.c
[]
quoted hunk ↗ jump to hunk
@@ -668,7 +668,7 @@ void wiphy_unregister(struct wiphy *wiphy) mutex_lock(&rdev->devlist_mtx); __count = rdev->opencount; mutex_unlock(&rdev->devlist_mtx); - __count == 0;})); + __count == 0; }));
Inline statement expressions are pretty unusual
for kernel sources. Normally these are used via
macro.
I'd try to make the statement expression visually
distinct. Something like:
wait_event(rdev->dev_wait,
({
int __count;
mutex_lock(&rdev->devlist_mtx);
__count = rdev->opencount;
mutex_unlock(&rdev->devlist_mtx);
__count == 0;
})
);