Re: [PATCH 3.3] mwifiex: remove redundant scan operation
From: John W. Linville <hidden>
Date: 2012-02-27 23:26:47
On Fri, Feb 24, 2012 at 09:35:36PM -0800, Bing Zhao wrote:
quoted hunk ↗ jump to hunk
From: Amitkumar Karwar <redacted> It should have been removed by commit "mwifiex: use cfg80211 dynamic scan..." (7c6fa2a843..) after adding code to avoid an extra scan during association because scan entries are valid for 15 seconds in cfg80211 stack. Signed-off-by: Amitkumar Karwar <redacted> Signed-off-by: Bing Zhao <redacted> --- drivers/net/wireless/mwifiex/cfg80211.c | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-)diff --git a/drivers/net/wireless/mwifiex/cfg80211.c b/drivers/net/wireless/mwifiex/cfg80211.c index e4e6d7d..7b98ce0 100644 --- a/drivers/net/wireless/mwifiex/cfg80211.c +++ b/drivers/net/wireless/mwifiex/cfg80211.c@@ -924,12 +924,6 @@ mwifiex_cfg80211_assoc(struct mwifiex_private *priv, size_t ssid_len, u8 *ssid, } } done: - /* Do specific SSID scanning */ - if (mwifiex_request_scan(priv, &req_ssid)) { - dev_err(priv->adapter->dev, "scan error\n"); - return -EFAULT; - } - /* * Scan entries are valid for some time (15 sec). So we can save one * active scan time if we just try cfg80211_get_bss first. If it fails
It seems like this could wait to be fixed in 3.4? -- John W. Linville Someday the world will need a hero, and you linville@tuxdriver.com might be all we have. Be ready.