[PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req

Subsystems: networking drivers (wireless), the rest

STALE5299d

2 messages, 2 authors, 2012-01-31 · open the first message on its own page

[PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req

From: Devendra.Naga <hidden>
Date: 2012-01-31 06:37:22

From: "Devendra.Naga" <redacted>

the return value from _rtl_pci_switch_clk_req is not used by any of its callers.

Signed-off-by: Devendra.Naga <redacted>
---
 drivers/net/wireless/rtlwifi/pci.c |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 5cb2199..9a01909 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
 }
 
 /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
-static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
+static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
 {
 	struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
 	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -207,8 +207,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
 
 	if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
 		udelay(100);
-
-	return true;
 }
 
 /*Disable RTL8192SE ASPM & Disable Pci Bridge ASPM*/
-- 
1.7.5.4

Re: [PATCH] rtlwifi: remove return in _rtl_pci_switch_clk_req

From: Larry Finger <hidden>
Date: 2012-01-31 15:52:29

On 01/31/2012 12:28 AM, Devendra.Naga wrote:
From: "Devendra.Naga"<redacted>

the return value from _rtl_pci_switch_clk_req is not used by any of its callers.

Signed-off-by: Devendra.Naga<redacted>
---
  drivers/net/wireless/rtlwifi/pci.c |    4 +---
  1 files changed, 1 insertions(+), 3 deletions(-)
Acked-by: Larry Finger <redacted>

Thanks,

Larry
quoted hunk
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 5cb2199..9a01909 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
  }

  /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
-static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
+static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
  {
  	struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
  	struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -207,8 +207,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)

  	if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
  		udelay(100);
-
-	return true;
  }

  /*Disable RTL8192SE ASPM&  Disable Pci Bridge ASPM*/

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help