Re: [PATCH 1/1] wireless: in _rtl92c_phy_calculate_bit_shift remove comparing bitmask against 1
From: Larry Finger <hidden>
Date: 2012-01-30 23:36:56
Also in:
lkml, netdev
On 01/30/2012 04:00 AM, Devendra.Naga wrote:
From: "Devendra.Naga"<redacted>
in _rtl92c_phy_calculate_bit_shift everytime the right shifted bitmask
is AND with 1 and compared against 1. i.e.
if ((bitmask>> i)& 0x1 == 1)
break;
which in the if condition is anyway becomes a 1 or 0.
Signed-off-by: Devendra.Naga<redacted>Once again, the patch is OK, but the subject is not good. Larry
quoted hunk ↗ jump to hunk
--- drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c index 22e998d..a76b223 100644 --- a/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c +++ b/drivers/net/wireless/rtlwifi/rtl8192c/phy_common.c@@ -177,7 +177,7 @@ u32 _rtl92c_phy_calculate_bit_shift(u32 bitmask) u32 i; for (i = 0; i<= 31; i++) { - if (((bitmask>> i)& 0x1) == 1) + if ((bitmask>> i)& 0x1) break; } return i;