Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
From: Larry Finger <hidden>
Date: 2012-01-30 23:35:47
Also in:
lkml, netdev
On 01/30/2012 06:46 AM, Devendra.Naga wrote:
From: "Devendra.Naga"<redacted> the return value from _rtl_pci_switch_clk_req is not used by any of its callers. Signed-off-by: Devendra.Naga<redacted> --- drivers/net/wireless/rtlwifi/pci.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
The patch is OK, but the patch subject is bad. You should have "[PATCH] rtlwifi:...". Your patch is for rtlwifi, not wireless. Larry
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c index 4326fd1..35f4a0d 100644 --- a/drivers/net/wireless/rtlwifi/pci.c +++ b/drivers/net/wireless/rtlwifi/pci.c@@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm( } /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/ -static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) +static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) { struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw)); struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));@@ -208,7 +208,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value) if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE) udelay(100); - return true; } /*Disable RTL8192SE ASPM& Disable Pci Bridge ASPM*/