On 01/05/2012 01:41 AM, Joe Perches wrote:

On Thu, 2012-01-05 at 01:09 +0200, Kalle Valo wrote:

quoted

That way it's possible to not export debug_mask outside the upcoming
ath6kl_core.ko and that makes it easier to ath6kl_core.ko in the
following patch.

[]

quoted

Signed-off-by: Kalle Valo <redacted>

[]

quoted

diff --git a/drivers/net/wireless/ath/ath6kl/debug.c b/drivers/net/wireless/ath/ath6kl/debug.c

[]

quoted

+void ath6kl_dbg(enum ATH6K_DEBUG_MASK mask, const char *fmt, ...)
+{
+	va_list args;
+
+	if (!(debug_mask & mask))
+		return;
+
+	va_start(args, fmt);
+	ath6kl_printk(KERN_DEBUG, fmt, &args);

Passing a va_list as an argument?
I believe this doesn't work.

Doh, I was supposed to test this but then I forgot in the hurry. Thanks
for pointing this out. I will send v2 which will fix this.

Kalle