Thread (29 messages) read the whole thread 29 messages, 4 authors, 2012-01-24

Re: Compat-wireless-3.2-rc6-3 is broken for rt2860 device

From: Stanislaw Gruszka <hidden>
Date: 2012-01-24 07:29:53
Subsystem: networking drivers (wireless), the rest · Maintainers: Johannes Berg, Linus Torvalds

On Mon, Jan 23, 2012 at 02:29:08PM +0100, Helmut Schaa wrote:
On Fri, Jan 20, 2012 at 8:29 AM, Andreas Hartmann
[off-list ref] wrote:
quoted
All in one: Your workaround was a good idea, but unfortunately it
doesn't "solve" / workaround the problem introduced with the patch
"mac80211: retry sending failed BAR frames later instead of tearing
down aggr" [1]. I don't know off any other solution at this time as to revert it.
Ok, so we've got at least one hw issue here: rt2800 is not able to report
correct ACK state of BARs :(
Whould it help, if rt2800 driver will not filter out BAR frames?
diff --git a/drivers/net/wireless/rt2x00/rt2800lib.c b/drivers/net/wireless/rt2x00/rt2800lib.c
index 22a1a8f..20418be 100644
--- a/drivers/net/wireless/rt2x00/rt2800lib.c
+++ b/drivers/net/wireless/rt2x00/rt2800lib.c
@@ -1205,8 +1205,7 @@ void rt2800_config_filter(struct rt2x00_dev *rt2x00dev,
 			   !(filter_flags & FIF_PSPOLL));
 	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_BA,
 			   !(filter_flags & FIF_CONTROL));
-	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_BAR,
-			   !(filter_flags & FIF_CONTROL));
+	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_BAR, 0);
 	rt2x00_set_field32(&reg, RX_FILTER_CFG_DROP_CNTL,
 			   !(filter_flags & FIF_CONTROL));
 	rt2800_register_write(rt2x00dev, RX_FILTER_CFG, reg);

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help