Thread (50 messages) 50 messages, 5 authors, 2012-03-15

Re: [RFC 9/9] mac80211: add DFS support to monitor interface

From: Christian Lamparter <chunkeey@googlemail.com>
Date: 2012-01-26 14:10:32

On Thursday, January 26, 2012 01:38:04 PM Victor Goldenshtein wrote:
quoted hunk ↗ jump to hunk
Stop dropping packets if we are on 'radar channel'
and the DFS is enabled/supported.

Signed-off-by: Victor Goldenshtein <redacted>
---
 net/mac80211/tx.c |   15 +++++++++------
 1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index edcd1c7..2c728a4 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1581,15 +1583,16 @@ netdev_tx_t ieee80211_monitor_start_xmit(struct sk_buff *skb,
 	 * flag.
 	 *
 	 * Since AP mode uses monitor interfaces to inject/TX management
-	 * frames we can make AP mode the exception to this rule once it
-	 * supports radar detection as its implementation can deal with
-	 * radar detection by itself. We can do that later by adding a
-	 * monitor flag interfaces used for AP support.
+	 * frames we can make AP mode the exception to this rule, in the
+	 * case the driver supports radar detection, allow usage of radar
+	 * channels.
 	 */
Hey, that's great!

I have one question: Wasn't the monitor interface [for AP mode] being
rendered obsolete by Johannes cfg80211-internal-ap-mlme work? If so,
then we could save us the work here, right?

BTW, what about cfg80211_can_beacon_sec_chan in net/wireless/chan.c?
I think it needs to be updated or else we can't have HT40 [secondary
channels] on frequencies which require DFS.

Regards,
	Chr
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help