Thread (16 messages) flat view 16 messages, 9 authors, 2012-01-07

Re: Question about IEEE80211_TX_CTL_NO_ACK in ath_9k

From: Mohammed Shafi <hidden>
Date: 2011-12-19 12:33:20
Subsystem: mac80211, the rest · Maintainers: Johannes Berg, Linus Torvalds

2011/12/19 李刚 [off-list ref]:
Hi everybody!

My wireless card is AR9280. I set the IEEE80211_TX_CTL_NO_ACK flag before
send a packet, but found it no use. It still wait for an ACK. Then I read
the code,
may be any of the following hacks may work ?
@@ -1039,6 +1039,9 @@ static void ath_tx_fill_desc(struct ath_softc
*sc, struct ath_buf *bf,
        info.qcu = txq->axq_qnum;

        info.flags = ATH9K_TXDESC_INTREQ;
+
+               info.flags |= ATH9K_TXDESC_NOACK;
+
        if (tx_info->flags & IEEE80211_TX_CTL_NO_ACK)
                info.flags |= ATH9K_TXDESC_NOACK;
        if (tx_info->flags & IEEE80211_TX_CTL_LDPC)

(or)
diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
index edcd1c7..0454dee 100644
--- a/net/mac80211/tx.c
+++ b/net/mac80211/tx.c
@@ -1185,6 +1185,8 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
        } else
                tx->flags |= IEEE80211_TX_UNICAST;

+               info->flags |= IEEE80211_TX_CTL_NO_ACK;
+
        if (!(info->flags & IEEE80211_TX_CTL_DONTFRAG)) {
                if (!(tx->flags & IEEE80211_TX_UNICAST) ||
                    skb->len + FCS_LEN <= local->hw.wiphy->frag_threshold ||


-- 
shafi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help