Re: [PATCH 1/2] iwlegacy: change IWL_WARN to IWL_DEBUG_HT in iwl4965_tx_agg_start
From: Stanislaw Gruszka <hidden>
Date: 2011-09-08 23:29:45
Also in:
lkml, netdev
Hi Greg On Wed, Sep 07, 2011 at 10:51:26PM -0500, Greg Dietsche wrote:
On 09/06/2011 10:01 AM, Stanislaw Gruszka wrote:quoted
I put patches here: http://people.redhat.com/sgruszka/iwlegacy_cleanup.tar.bz2 They are on top of wireless-testing tree.<snip>quoted
Series include your 2 patches. You can test this cleanup and apply your new changes on top. I'll not do any further cleanup for some time now, perhaps continue when I got public git tree.Thanks! I've re-worked my patches and you can find them here: http://www.gregd.org/stuff/linux/iwlegacy_cleanup_greg.tar.bz2 I also decided to play with github a little bit: git://github.com/dietsche/linux.git and pushed two branches: 1) wireless-next-iwlegacy-stanislaw - your patch set 2) wireless-next-iwlegacy-stanislaw-greg - a branch that has my additional patches. `git format-patch wireless-next-iwlegacy-stanislaw..wireless-next-iwlegacy-stanislaw-greg` will generate the patches that are in the link i posted above.
Cool!
The first two patches in my series are the ones that I think folks should take a closer look at. The rest are pretty safe.
The second patch is ok. I'm not sure about first one, but we can get rid of "ctx = il_rxon_ctx_from_vif(vif)" at all, because we have only one context. Removing il_rxon_context structure from iwlegacy driver is my long term plan, you can look at that if you wish. Thanks Stanislaw