Re: [PATCH 16/20] staging: brcm80211: declared global vars in softmac phy as const
From: Julian Andres Klode <hidden>
Date: 2011-09-24 09:52:53
On Fri, Sep 23, 2011 at 07:09:04PM -0700, Franky Lin wrote:
quoted hunk ↗ jump to hunk
From: Roland Vossen <redacted> Global variables are undesirable unless they are read only. Reported-by: Johannes Berg <johannes@sipsolutions.net> Reviewed-by: Pieter-Paul Giesberts <redacted> Reviewed-by: Arend van Spriel <redacted> Signed-off-by: Franky Lin <redacted> ---diff --git a/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c b/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c index 15c5ffc..1b11b2f 100644 --- a/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c +++ b/drivers/staging/brcm80211/brcmsmac/phy/phytbl_lcn.c@@ -1611,7 +1611,7 @@ const u32 dot11lcnphytbl_rx_gain_info_sz_rev0 = sizeof(dot11lcnphytbl_rx_gain_info_rev0) / sizeof(dot11lcnphytbl_rx_gain_info_rev0[0]); -static const u32 dot11lcnphytbl_rx_gain_info_sz_rev1 = +const u32 dot11lcnphytbl_rx_gain_info_sz_rev1 = sizeof(dot11lcnphytbl_rx_gain_info_rev1) / sizeof(dot11lcnphytbl_rx_gain_info_rev1[0]);
That seems like an anomaly. In a commit that is supposed to declare variables as const, the linkage of a variable changed. Likewise, the removal of extern global variable declarations in phy_int.h also does not seem to belong here. -- Julian Andres Klode - Debian Developer, Ubuntu Member See http://wiki.debian.org/JulianAndresKlode and http://jak-linux.org/.