On Thu, 2011-09-29 at 12:02 +0200, Helmut Schaa wrote:

quoted

Makes sense, but I wonder if we really should continue using
radiotap :-) Maybe mgmt-tx in nl80211 would be appropriate.

An nl80211 flag, and the right modifications in hostapd to use mgmt-tx
and the flag. But I guess that's just another thing on the growing list
of things to do to move hostapd to not use monitor interfaces ...

Hmm, not sure how much work that would be ...

quoted

quoted

@@ -1257,7 +1265,7 @@ ieee80211_tx_prepare(struct ieee80211_sub_if_data *sdata,
              tx->flags |= IEEE80211_TX_UNICAST;
              if (unlikely(local->wifi_wme_noack_test))
                      info->flags |= IEEE80211_TX_CTL_NO_ACK;
-             else
+             else if (!(info->flags & IEEE80211_TX_CTL_NO_ACK))
                      info->flags &= ~IEEE80211_TX_CTL_NO_ACK;

??

Don't remove the IEEE80211_TX_CTL_NO_ACK flag when it was set via radiotap.

Well, ok, but the logic is:

if (flag not set)
	unset flag

which is kinda useless, right?

johannes