On Mon, 2011-09-26 at 13:29 +0300, Levi, Shahar wrote: 

On Mon, Sep 26, 2011 at 9:25 AM, Luciano Coelho [off-list ref] wrote:

quoted

On Sun, 2011-09-25 at 19:08 +0300, Levi, Shahar wrote:

quoted

On Fri, Sep 23, 2011 at 1:59 PM, Luciano Coelho [off-list ref] wrote:

quoted

I'm leaving this patch out for now until I understand this better.

Do you prefer me to set v2 without that line or you could fix that in
the apply stage?

No need to send v2.  It seems that Victor will need this change for
something else he's working on, so I guess he can take it over once it
is needed.  I don't want to include this unless we have a good reason to
do it.

There is a good reason to include this:
a) It solve STA calibration issue in the FW in case of SW channel
switch (Rx issues)

This is a good reason (fixing a bug) and should be mentioned in the
commit description.  Do we have more detailed information on this?

b) This is FW support for channel switch with one command instead of
using several commands: rate_policies, roc \ join...

This is an optimization and not entirely mandatory.  This is the only
thing I thought this patch was addressing (the commit message was not
very descriptive, so I could only assume).  At this stage (ie. close to
the merge window), I didn't want to assume the risk of a change just for
to optimize things a bit.  And, since I had my doubts about the block_tx
value, I decided not to include it.

Our latest version pass full test cycle with that fix that solve CS issues.

Okay, once I get the answer from the firmware team about the block_tx
value, I'll fix up this patch and apply it.

Thanks for the explanantions.

-- 
Cheers,
Luca.