On Mon, Sep 26, 2011 at 07:27:43AM -0600, Felix Fietkau wrote:

On 2011-09-26 3:42 AM, Rajkumar Manoharan wrote:

quoted

The recent changes of ath_tx_rc_status makes it to be called
only for the first frame of aggregation or if there is a
single subframe and for all normal frames. And also for all
aggregated frames IEEE80211_TX_STAT_AMPDU will be set. This
patch removes the unnecessary checks and make the ampdu_[ack]_len
to be filled on both aggregation and normal frames.

This patch looks wrong to me. Only one subframe per A-MPDU is
supposed to carry the IEEE80211_TX_STAT_AMPDU flag, so the check you
removed from rc.c is actually necessary, otherwise it'll process the
tx status of an A-MPDU multiple times (once per completed subframe).

I dont understand. Right now ath_tx_rc_status is called only for the first
frame of aggregation or there is only one subframe in the aggregation.
It never be called for all subframes. Am i right?

--
Rajkumar