Thread (7 messages) flat view 7 messages, 2 authors, 2011-08-16

Re: [PATCH 1/2] mac80211: refactor sta_info_insert_rcu to 3 main stages

From: Guy Eilam <hidden>
Date: 2011-08-09 09:02:10

On Mon, Aug 8, 2011 at 4:35 PM, Johannes Berg [off-list ref] wrote:
Just a cursory look, I'll send a more detailed review later, but I
wanted to ask John to not merge this for now;
quoted
+static int sta_info_insert_adhoc(struct sta_info *sta) __acquires(RCU)
_ibss would be preferred
quoted
+static int sta_info_insert_mgd(struct sta_info *sta) __acquires(RCU)
_mgd is terribly misleading, this will be done for all modes other than
IBSS.
Fair enough. the _ibss change is logical and understood.
The problem with the _mgd function is that it will be silly to call it
_non_ibss (or is it?)
Do you have a suggestion for a better name?
johannes

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help