Re: [PATCH 1/2] mac80211: add flag to indicate HW only Tx-agg support
From: Arik Nemtsov <hidden>
Date: 2011-08-29 19:43:42
On Mon, Aug 29, 2011 at 09:21, Johannes Berg [off-list ref] wrote:
On Thu, 2011-08-25 at 12:51 +0300, Arik Nemtsov wrote:quoted
When this flag is set, Tx aggregations will not be initiated even if the hardware supports A-MPDU aggregation in general. This flag is required for devices supporting (partial) software Rx-aggregation. Signed-off-by: Arik Nemtsov <redacted> --- include/net/mac80211.h | 4 ++++ net/mac80211/agg-tx.c | 3 ++- net/mac80211/debugfs.c | 2 ++ net/mac80211/tx.c | 3 ++- 4 files changed, 10 insertions(+), 2 deletions(-)diff --git a/include/net/mac80211.h b/include/net/mac80211.h index 2f01d84..b21a5bb 100644 --- a/include/net/mac80211.h +++ b/include/net/mac80211.h@@ -1094,6 +1094,9 @@ enum sta_notify_cmd {* stations based on the PM bit of incoming frames. * Use ieee80211_start_ps()/ieee8021_end_ps() to manually configure * the PS mode of connected stations. + * + * @IEEE80211_HW_TX_AMPDU_IN_HW_ONLY: The device handles TX aggregation + * strictly in HW. Packets should not be aggregated in software.In addition to the discussion with Helmut -- this is also misleading since mac80211 doesn't, right now, aggregate anything in software -- it just handles session setup (which is what you don't want).
Sure. I'll rename it to something like IEEE80211_HW_TX_AMPDU_SETUP_IN_HW (and change the description). Arik