Re: [patch] libertas: remove some dead code in if_spi_prog_helper_firmware()
From: Dan Williams <hidden>
Date: 2011-08-15 22:51:54
Also in:
kernel-janitors
On Sat, 2011-08-06 at 07:23 -0700, Dan Carpenter wrote:
We always hit the goto and skip the printk(). The original code does the right thing even though it looks messy. Signed-off-by: Dan Carpenter <redacted>
Acked-by: Dan Williams <redacted>
quoted hunk ↗ jump to hunk
diff --git a/drivers/net/wireless/libertas/if_spi.c b/drivers/net/wireless/libertas/if_spi.c index e0286cf..622ae6d 100644 --- a/drivers/net/wireless/libertas/if_spi.c +++ b/drivers/net/wireless/libertas/if_spi.c@@ -531,10 +531,6 @@ static int if_spi_prog_helper_firmware(struct if_spi_card *card, goto out; err = spu_write_u16(card, IF_SPI_CARD_INT_CAUSE_REG, IF_SPI_CIC_CMD_DOWNLOAD_OVER); - goto out; - - lbs_deb_spi("waiting for helper to boot...\n"); - out: if (err) pr_err("failed to load helper firmware (err=%d)\n", err);