Thread (2 messages) 2 messages, 2 authors, 2011-08-31
STALE5417d

[patch -next 2/2] iwlwifi: signedness bug in iwl_trans_pcie_tx_agg_alloc()

From: Dan Carpenter <hidden>
Date: 2011-08-31 06:38:30
Also in: kernel-janitors
Subsystem: networking drivers (wireless), the rest · Maintainers: Johannes Berg, Linus Torvalds

unsigned shorts and unsigned chars are never == -1.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
index 5dd6a6d..ea6a0bc 100644
--- a/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
+++ b/drivers/net/wireless/iwlwifi/iwl-trans-tx-pcie.c
@@ -535,7 +535,7 @@ int iwl_trans_pcie_tx_agg_alloc(struct iwl_trans *trans,
 	struct iwl_trans_pcie *trans_pcie = IWL_TRANS_GET_PCIE_TRANS(trans);
 	struct iwl_tid_data *tid_data;
 	unsigned long flags;
-	u16 txq_id;
+	int txq_id;
 	struct iwl_priv *priv = priv(trans);
 
 	txq_id = iwlagn_txq_ctx_activate_free(trans);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help