Re: [patch -next] wl12xx: fix recent change to wl1271_tm_cmd_nvs_push()
From: Luciano Coelho <hidden>
Date: 2011-08-24 14:18:41
Also in:
kernel-janitors
From: Luciano Coelho <hidden>
Date: 2011-08-24 14:18:41
Also in:
kernel-janitors
Hi Dan, On Wed, 2011-08-24 at 14:31 +0300, Dan Carpenter wrote:
bc765bf3b9a "wl12xx: 1281/1283 support - Loading FW & NVS" had two problems. The condition was written so that it failed if "len" was not equal to sizeof(struct wl1271_nvs_file). Also we need to release the locks on these new error paths. Signed-off-by: Dan Carpenter <redacted>
Thanks for your patch. But we have just removed this function, since the implementation was broken and the feature is not really used anymore. The patch that removes this function entirely is already queued for inclusion on the 3.1-rc series: http://git.kernel.org/?p=linux/kernel/git/linville/wireless.git;a=commit;h=80900d0140a7648587982c8f299830e900e49165 -- Cheers, Luca.