Thread (8 messages) 8 messages, 3 authors, 2011-08-24

Re: [patch -next] bcma: signedness bug in bcma_get_next_core()

From: Rafał Miłecki <zajec5@gmail.com>
Date: 2011-08-20 12:23:56
Also in: kernel-janitors

W dniu 18 sierpnia 2011 15:38 użytkownik Dan Carpenter
[off-list ref] napisał:
The u32 would never be less than zero so the error handling would
break.  I changed it to int.
In declaration we use s32:
static s32 bcma_erom_get_mst_port(struct bcma_bus *bus, u32 **eromptr);

Doesn't it sound better to use s32 instead of int?

-- 
Rafał
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help