Re: [PATCH] iwlagn: check for !priv->txq in iwlagn_wait_tx_queue_empty

On Mon, 2011-07-25 at 13:03 -0700, Keith Packard wrote:

On Mon, 25 Jul 2011 12:21:55 -0700, "Guy, Wey-Yi" [off-list ref] wrote:

quoted

but why you need it?, "start device" call will fail if can not allocate
priv->txq

The device is down, so start_device was never called. At least, that's
my assumption -- I've got the wireless device 'disabled' in
NetworkManager.

the iwlagn_wait_tx_queue_empty() function only can be call from either
"flush" operation or from debugfs. I agree it is a problem if call from
debugfs. did you actually see the problem when it is not from debugfs().

there is a recent patch in mac80211 to make sure do not call "flush" is
not needed.

Thanks
Wey