Re: [PATCH] b43legacy: remove 64-bit DMA support

On 07/26/2011 02:02 PM, Pavel Roskin wrote:

On 07/26/2011 01:47 PM, Larry Finger wrote:

quoted

On 07/25/2011 04:40 PM, Pavel Roskin wrote:

quoted

Devices supported by b43legacy don't support 64-bit DMA.

Signed-off-by: Pavel Roskin<redacted>
---
The patch was tested on Broadcom 4306.

drivers/net/wireless/b43legacy/dma.c | 374
++++++----------------------------
drivers/net/wireless/b43legacy/dma.h | 107 ----------
2 files changed, 71 insertions(+), 410 deletions(-)

Tested on BCM4303.

Appreciated!

quoted

quoted

+ value&= B43legacy_DMA32_RXSTATE;

I am surprised that checkpatch doesn't see the spacing around the &= as
an error.

It's a Mozilla Thunderbird bug. What you are seeing is not what I sent.

checkpatch would catch that in the real code.

Ahh. The BCM4303 is in a different machine than I the one used to do Email. Saving the message from Thunderbird to an NFS-mounted device and copying to the test machine came out right. When I saw it in the mail, I ran checkpatch, saw that it was clean, and failed to check the actual patch that I had applied. Interesting.

Larry