Re: problem on ACS
flat view
From: Christian Lamparter <chunkeey@googlemail.com>
Date: 2011-07-30 11:14:29
Possibly related (same subject, not in this thread)
- 2011-08-01 · Re: problem on ACS · Luis R. Rodriguez <hidden>
- 2011-07-27 · Re: problem on ACS · Luis R. Rodriguez <hidden>
- 2011-07-27 · Re: problem on ACS · Swaminathan Vasanth <hidden>
- 2011-07-27 · Re: problem on ACS · Luis R. Rodriguez <hidden>
- 2011-07-26 · Re: problem on ACS · Luis R. Rodriguez <hidden>
On Friday 29 July 2011 22:50:54 Luis R. Rodriguez wrote:
On Fri, Jul 29, 2011 at 12:39 AM, MingAnn Ng [off-list ref] wrote:quoted
Survey 2 from wlan0: noise: -84 dBm channel active time: 12 ms channel busy time: 0 ms channel receive time: 0 ms channel transmit time: 0 ms interference factor: 9223372036854775815.000000This is caused by log2(0), this if fixed as follows:
quoted hunk ↗ jump to hunk
diff --git a/src/ap/acs.c b/src/ap/acs.c index aa5498e..04b1e31 100644 --- a/src/ap/acs.c +++ b/src/ap/acs.c@@ -125,7 +125,7 @@ static u64 min(u64 a, u64 b) */ static u64 log2_sane(u64 val) { - return log2(min(1073741824, val)); + return return (!val) ? 0 : log2(min(1073741824, val)); }I'll send a new version of the last patch with this fix, thanks for reporting this.
Wait a sec... I guess you misunderstood my post about the cut-off. I meant that you can cut of at the bottom by using log2(max(1, val)). This ensures that the log2 will always be >= 0 anyway. In fact log2(1) = 0. Regards, Chr