Re: [PATCH v4 1/6] NFC: add nfc subsystem core
From: Joe Perches <joe@perches.com>
Date: 2011-06-28 20:18:46
On Tue, 2011-06-28 at 15:20 -0300, Aloisio Almeida Jr wrote:
From: Lauro Ramos Venancio <redacted> The NFC subsystem core is responsible for providing the device driver interface. It is also responsible for providing an interface to the control operations and data exchange.
[]
quoted hunk ↗ jump to hunk
diff --git a/net/nfc/nfc.h b/net/nfc/nfc.h
[]
+#define NFC_INFO(fmt, arg...) printk(KERN_INFO "NFC: " fmt "\n", ## arg)
+#define NFC_ERR(fmt, arg...) printk(KERN_ERR "%s: " fmt "\n", __func__, ## arg)
+#define NFC_DBG(fmt, arg...) pr_debug("%s: " fmt "\n", __func__, ## arg)I think these #defines and their uses would be better lower case. #define nfc_info(etc...) #define nfc_err(etc...) #define nfc_dbg(etc...) And because these don't really take any nfc specific struct as an argument, may be better removed altogether and replaced with the pr_<level> equivalents. I think emitting __func__ rarely adds useful information.