Re: [PATCH 12/25] sony-laptop: input core improvements improvements

On Sat, Jun 04, 2011 at 05:21:11PM +0200, Marco Chiappero wrote:

Il 04/06/2011 10:07, Mattia Dongili ha scritto:

quoted

quoted

of Fn combos too.

the additional key codes are fine though.

There is one thing (IIRC you already heard of) I'd like to discuss here.
It seems that on recent models the hotkeys layout hasn't changed for
some time now, and it's likely to stay the same for a long time.
However it is different from the one mapped in the driver, and some
changes are required. For example:

- Fn-F1 (Touchpad togle enable) to KEY_TOUCHPAD_TOGGLE instead of KEY_FN_F1
- Fn-F5 (bright. down) to KEY_BRIGHTNESSDOWN instead of KEY_FN_F5
- Fn-F9 (zoom out) to KEY_ZOOMOUT instead of KEY_FN_F9
and so on.

To preserve support for older models we can use udev keymaps or a
fallback map for any notebook not starting with the "VPC" model
prefix (since a couple of years this is the starting model string).
Is this solution acceptable? Having a correct mapping at the source
instead of remapping for every model is better, is it possible?

sure it's possible but it's going to be a source of headache once sony
changes their keyboard layout again (and it will happen).
Using generic key codes and remapping them in userspace where necessary
worked for more than 10 years and is still working fine.

-- 
mattia
:wq!