Thread (4 messages) 4 messages, 3 authors, 2011-05-29

Re: [PATCH 2/4] staging: Remove direct includes of printk.h

From: Joe Perches <joe@perches.com>
Date: 2011-05-29 20:40:48
Also in: lkml

On Sun, 2011-05-29 at 18:00 +0100, julie Sullivan wrote: 
quoted
--- a/drivers/staging/brcm80211/brcmfmac/dhd_sdio.c
[] 
types.h is also a subfile of kernel.h, right?
Yes it is.
Or maybe you patched this one already - if so please excuse the noise :-)
No I didn't patch that one.

I think it wouldn't be good to do that.
printk.h may be a special case because it was
moved out of kernel.h just to make it a bit neater.

You are welcome to if you choose to.

There are like 1500 or so files that have both kernel.h and types.h

$ grep --include=*.[ch] -rP -l "^\s*\#\s*include\s+\<linux/types\.h>" * | \
  xargs grep -Pl "^\s*\#\s*include\s+\<linux/kernel\.h\>" | wc -l
1572

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help