Re: ath5k regression associating with APs in 2.6.38
From: Seth Forshee <hidden>
Date: 2011-05-04 19:26:57
Also in:
lkml, netdev
On Wed, May 04, 2011 at 01:27:17PM -0400, John W. Linville wrote:
On Wed, May 04, 2011 at 10:38:19AM -0500, Seth Forshee wrote:quoted
I've been investigating some reports of a regression in associating with APs with AR2413 in 2.6.38. Association repeatedly fails with some "direct probe to x timed out" messages (see syslog excerpt below), although it will generally associate eventually, after many tries. Bisection identifies 8aec7af (ath5k: Support synth-only channel change for AR2413/AR5413) as offending commit. Prior to this commit there are no direct probe messages at all in the logs. I've also found that forcing fast to false at the top of ath5k_hw_reset() fixes the issue. I'm not sure what the connection is between this commit and the timeouts. Any suggestions?Have you tried reverting that commit on top of 2.6.38? Can you recreate the issue with 2.6.39-rc6 (or later)?
I started to revert that commit, but it wasn't straight-forward due to later changes. Forcing fast to false in ath5k_hw_reset() acts as a functional revert of sorts since that should force it back to a full reset for all channel changes, and it's much simpler than working out the right way to revert the commit. I think the results suggest strongly that a revert is likely to fix the problem. I can finish the work to revert if you'd still like to see the results. Testing a previous .39-rc kernel still exhibited the failure. I don't recall which one it was and apparently forgot to make note of it. I'll request testing against rc6. Thanks, Seth