On Wed, 2011-05-04 at 16:42 +0200, Felix Fietkau wrote:

On 2011-05-04 1:57 AM, Javier Cardona wrote:

quoted

Mesh beaconing on ath9k was broken by this commit:

commit 4801416c76a3a355076d6d371c00270dfe332e1c
Author: Ben Greear[off-list ref]
Date:   Sat Jan 15 19:13:48 2011 +0000

This patch assigns the right opmode when the device is used in mesh
mode.

Reported-by: Fabrice Deyber fabricedeyber@agilemesh.com
Signed-off-by: Javier Cardona<redacted>

Any idea why exactly ath9k needs to use this opmode? If I understand the 
specs correctly, 802.11s does not use distributed beacons like ad-hoc 
mode, so theoretically it should be fine with using the AP iftype.
If beacons don't work at all in this opmode for 802.11s then this patch 
may just be covering up an underlying bug rather than fixing the real issue.

- Felix
--

I'd tend to agree. I think the problem is in ath9k_allow_beacon_config
with the test about not configuring station vif's when in AP mode. I
think it's too restrictive. 

Maybe something like:

         * Can not configure station vif's beacon config
         * while on AP opmode
         */
        if ((sc->sc_ah->opmode == NL80211_IFTYPE_AP) &&
-           (vif->type != NL80211_IFTYPE_AP)) {
+           ((vif->type == NL80211_IFTYPE_STATION) ||
+            (vif->type == NL80211_IFTYPE_ADHOC))) {

Steve