Thread (5 messages) 5 messages, 3 authors, 2011-05-31

Re: [PATCH] wl12xx: Add Support for Low Power DRPw (LPD) Mode

From: Eliad Peller <hidden>
Date: 2011-05-31 09:11:10

On Tue, May 31, 2011 at 11:35 AM, Luciano Coelho [off-list ref] wrote:
On Tue, 2011-05-31 at 10:51 +0300, Shahar Levi wrote:
quoted
The Low Power DRPw (LPD) mode contains several optimizations
that designed to reduce the solution's consumption. The
purpose is to save current consumption in RX and Listen mode.

LPD setting apply only for wl127x AP mode (not wl128x)

Signed-off-by: Shahar Levi <redacted>
---
[...]


I still think this is not the right way to do it.  It doesn't make sense
to have it in the configuration parameters.  If you want to make it
configurable, it should be in the NVS file and the driver should clear
it when not in AP mode (and whoever generates the NVS needs to make sure
it's never set for wl128x).
please don't use the "blacklist" approach. it always gets broken at some point.
The other solution is to always set this flag when in wl127x in AP-mode,
in which case it doesn't need to be configurable at all.  That would be
the simplest solution and you could even use a quirk if it makes it
easier.
sounds much better.

Eliad.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help