Re: [PATCH 1/1] drivers: brcmaxi: provide amba axi functionality in separate module

On Tuesday 29 March 2011, Jiri Slaby wrote:

On 03/29/2011 11:40 AM, Arend van Spriel wrote:

quoted

--- /dev/null
+++ b/drivers/brcmaxi/axi.c

@@ -0,0 +1,786 @@

...

quoted

+/* resetctrl */
+#define	AIRC_RESET		1
+
+/* definition for specifying padding fields */
+#define	_PADLINE(line)	pad ## line
+#define	_XSTR(line)	_PADLINE(line)
+#define	PAD		_XSTR(__LINE__)
+
+/*
+ * struct aidmp - device management plugin "wrapper" registers.
+ */
+struct aidmp {

This looks like it should be __packed__.

Why that? Adding the packed attribute would enforce byte access but
not change the layout of the structure, so I think that would make
it worse not better.

	Arnd