Re: [PATCH 3/3] iwlwifi: ack,plcp check health changes
From: Guy, Wey-Yi <hidden>
Date: 2011-02-25 17:13:08
On Fri, 2011-02-25 at 07:57 -0800, Stanislaw Gruszka wrote:
Add module ack_check, and plcp_check parameters, Ack_check is disabled by default since is proved that check ack health can cause troubles. Plcp_check is enabled by default. Remove iwl_lib_ops methods, they are unneeded after iwlegacy driver split. Merge check health code into to iwl-rx.c and make functions static. Signed-off-by: Stanislaw Gruszka <redacted>
Acked-by: Wey-Yi Guy <redacted>
--- drivers/net/wireless/iwlwifi/iwl-1000.c | 2 - drivers/net/wireless/iwlwifi/iwl-2000.c | 2 - drivers/net/wireless/iwlwifi/iwl-5000.c | 4 - drivers/net/wireless/iwlwifi/iwl-6000.c | 4 - drivers/net/wireless/iwlwifi/iwl-agn-lib.c | 1 + drivers/net/wireless/iwlwifi/iwl-agn-rx.c | 87 --------------- drivers/net/wireless/iwlwifi/iwl-agn.c | 73 ++----------- drivers/net/wireless/iwlwifi/iwl-agn.h | 4 - drivers/net/wireless/iwlwifi/iwl-core.h | 9 +- drivers/net/wireless/iwlwifi/iwl-rx.c | 162 ++++++++++++++++++++++++++- 10 files changed, 167 insertions(+), 181 deletions(-)
looks good, just wonder should it split into 2 patches, one for module parameter, and the other for moving the function? Your call Wey