Re: [RFC] ath9k: Fix ath9k prevents CPU to enter C3 states
From: Mohammed Shafi <hidden>
Date: 2011-02-10 14:19:16
On Wednesday 09 February 2011 10:18 PM, Richard Schütz wrote:
quoted
From: Mohammed Shafi Shajakhan<redacted> The DMA latency issue is observed only in Intel pinetrail platforms but in the driver we had a default PM-QOS value of 55. This caused unnecessary power consumption and battery drain in other platforms. Address this issue by disabling PM-QOS by default by setting it's value as '0' and making code changes appropriately.This addresses the bug: https://bugzilla.kernel.org/show_bug.cgi?id=27532 If the user sees some DMA latency issue he can still use the pmqos as a module parameter to trade power for throughput as below: sudo modprobe ath9k pmqos=55 Signed-off-by: Mohammed Shafi Shajakhan<redacted>Acked-By: Richard Schütz<redacted>
Thanks, but we got to consider user space approach which Luis had mentioned.
Looks good to me with the exception of ATH9K_PM_QOS_DEFAULT_VALUE. But John already mentioned that.