Thread (27 messages) 27 messages, 6 authors, 2009-08-26

Re: [RFC/RFT] rtl8187: Implement rfkill support

From: Herton Ronaldo Krzesinski <hidden>
Date: 2009-08-26 16:57:08

Em Qua 26 Ago 2009, às 12:07:52, Hin-Tak Leung escreveu:
On Wed, Aug 26, 2009 at 3:34 PM, Johannes Berg[off-list ref] wrote:
quoted
On Wed, 2009-08-26 at 13:33 +0000, Hin-Tak Leung wrote:
quoted
quoted
Or wait ... are you using compat-wireless?
Yes, I am. I mentioned this and did wonder if the _backport/ part
in /sys/class is important.
Sorry, didn't see.

Anyway, that's pretty clearly the reason -- Luis added NETDEV_PRE_UP to
some compat*.h but obviously the kernel won't ever call that notifier,
so cfg80211 doesn't get a chance to reject the IFUP. No idea how to
handle that -- it'll be working fine in a regular tree.

Luis, the only way to handle that would be to manually call the PRE_UP
notifier from mac80211's subif_open() and if that returns an error
(warning: the calling convention is weird) return the error... that's
weird but would work.
Okay, that explains it. So I can have a Tested-by: ... I just grep for
Ok, I submitted now the patches.
NETDEV_PRE_UP in compat-wireless and it is only in
include/net/compat-2.6.31.h (not in 2.6.30) and I am on 2.6.30.5-X . I
can grab the rawhide 2.6.31 rpms and try it quickly;
and possibly look at some ugly quick hack backport that? Stay tuned.

Thanks for the help.

Hin-Tak
--
[]'s
Herton
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help