Re: [PATCH] sony-laptop: no need to unblock rfkill on load

On Mon, Jun 08, 2009 at 12:36:58PM +0200, Johannes Berg wrote:

On Mon, 2009-06-08 at 11:31 +0100, Alan Jenkins wrote:

quoted

The re-written rfkill core ensures rfkill devices are initialized to
the system default state.  The core calls set_block after registration
so the driver shouldn't need to.

Signed-off-by: Alan Jenkins <redacted>

Good catch, thanks.

Just to confirm, is this patch going to sit in the wireless-testing tree
and you will submit it for inclusion together with the rfkill work
right?
 

quoted

---

This patch applies on top of the rfkill rewrite in the wireless-testing tree.

diff --git a/drivers/platform/x86/sony-laptop.c b/drivers/platform/x86/sony-laptop.c
index aec0b27..c1b21a4 100644
--- a/drivers/platform/x86/sony-laptop.c
+++ b/drivers/platform/x86/sony-laptop.c

@@ -1114,7 +1114,6 @@ static int sony_nc_setup_rfkill(struct acpi_device *device,
 		return err;
 	}
 	sony_rfkill_devices[nc_type] = rfk;
-	sony_nc_rfkill_set((void *)nc_type, false);
 	return err;
 }
 

thanks
-- 
mattia
:wq!