Re: [PATCH] rfkill: create useful userspace interface
From: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Date: 2009-06-01 13:33:52
On Mon, 01 Jun 2009, Johannes Berg wrote:
quoted
I mean platform devices which remember state. Those will be turned on/off by the platform firmware at boot and often at resume time, and overriding them in rfkill (especially if it is done later, by a rfkilld) will cause some flicker (on/off/on, off/on/off) in certain situations. This is a regression, because the current interface doesn't suffer this limitation.Right, but that was already covered by the discussion and patch I just sent, no need to complain, afaict? What's your gripe with the current add-on patch that I just sent out?
I don't know if I have any gripes with your latest patch ;) Can't test it right now. I was reacting to the comments in the thread. On a related note, Johannes, would you be opposed to exporting something I could call from thinkpad-acpi to request a radio state change on a rfkill struct? This would allow me to remove some of the mess in thinkpad-acpi. -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh