Re: [ath5k-devel] [PATCH 4/5] ath5k: Update initvals
From: Nick Kossifidis <mickflemm@gmail.com>
Date: 2009-02-01 04:36:23
2009/2/1 Bob Copeland [off-list ref]:
On Sat, Jan 31, 2009 at 04:30:07AM +0200, Nick Kossifidis wrote:quoted
* Update initvals to match legacy and Sam's HAL Signed-Off-by: Nick Kossifidis [off-list ref]I spot checked some of these, this is the only thing I saw:quoted
- { AR5K_BEACON_CNT_5211, 0x00000000 }, /* change */ + { AR5K_FRAME_CTL_QOSM, 0x000fc78f },legacy-hal and Sam disagree on the top 12 bits (0xffffc78f vs 0x000fc78f), we have Sam's.
According to docs, this is the aes mute mask and upper bits are the
aes mute mask for TID (traffic identifier) field used in QoS. So Sam
disables the TID thing on his HAL and legacy HAL leaves it unmasked.
It seems they also disable it on ath9k (have i mentioned that we have
many things in common ? :P) so i go with Sam's choice.
from ath9k's initvals.h
{ 0x0000805c, 0x000fc78f }
Rest looks good to me, feel free to add my Acked-by if you want.
-- GPG ID: 0xD21DB2DB As you read this post global entropy rises. Have Fun ;-) Nick