On Thu, 2008-12-11 at 19:02 +0100, Henning Rogge wrote:

Okay... I have included a casting to s8 into cfg.c so everyone is warned... 
the original signal field in the sta_info struct is an int, but this structure 
is used by the drivers so I don't want to touch it.

Right, not sure what happens when it's not in dBm anyway.

quoted

Can you also send me the corresponding iw patch?

Have to write a modified one, I will post it later this evening I think.

Ok. I noticed a few more things, sorry:

+ * enum nl80211_rate_info - bitrate information
+ *
+ * These attribute types are used with %NL80211_STA_INFO_TXRATE
+ * when getting information about the bitrate of a station.
+ *
+ * @__NL80211_RATE_INFO_INVALID: attribute number 0 is reserved
+ * @NL80211_RATE_INFO_BITRATE: total bitrate (u16, 100kbit/s)
+ * @NL80211_RATE_INFO_MCS: mcs index for 802.11n (u8)
+ * @NL80211_RATE_INFO_40_MHZ_WIDTH: 40 Mhz dualchannel bitrate
+ * @NL80211_RATE_INFO_SHORT_GI: 400ns guard interval

This needs documentation for __...after_last and ..._max too, I think,
or kernel-doc will complain, and then I get email on the next daily git
update and complain ;)

Other than that,

Acked-by: Johannes Berg <johannes@sipsolutions.net>

so feel free to add that into the patch when you resend.

johannes