On Thu, 2008-10-30 at 17:04 +0200, Jouni Malinen wrote:

This introduces a debugfs file (mac80211_hwsim/phy#/ps) that can be
used

Why not use the cfg80211-provided debugfs dir /ieee80211/phy#/ and maybe
put it below hwsim/ in there because mac80211 has things in there too?
That way you save all the code setting up the directory etc.

Mode 2 (automatic PS-Poll) does not yet parse Beacon frames, but
eventually, it should take a look at TIM IE and send PS-Poll if a
traffic bit is set for our AID.

Out of curiosity, is there any hw that implements this? b43 surely would
need such code too, and then it could be in mac80211? I can see setting
the PM bit be a decision of the driver, but if more than one driver ends
up needing ps-poll, maybe mac80211 should be handling it?

johannes