Re: [PATCH] rt2x00: Consolidate definition of CSR_OFFSET

On Fri, Sep 19, 2008 at 2:16 AM, John Daiker [off-list ref] wrote:

This consolidates the definition of CSR_OFFSET when CONFIG_RT2X00_LIB_DEBUG
is also set.
The original definition appeared in 5 files, but was moved to a common .h
file instead.

Compile-tested only, as I don't have any rt2x00 HW in a working machine.

Signed-off-by: John Daiker <redacted>

NACK
This patch does more then consolidating  the CRS_OFFSET definition since it
changes several lines for adding/removing whitespaces as well.
It completely breaks rt2500usb, and I really dislike using define
names in rt2x00.h
while the define itself is declared in the register headers only (and
is thus not really
visible in rt2x00.h, even though the compiler would accept it and it
would work as
expected).

Ivo

---